Use strcmp instead of spaceship operator to compare objects #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driehle
force-pushed
the
bugfix/compare-objects
branch
from
1bfa263 to
1aca22f
Compare
driehle
force-pushed
the
bugfix/compare-objects
branch
from
86a1de1 to
ab1def6
Compare
driehle
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
Looks good. I tried to come up with a failing test case, but since SPL object hashs are different on every run and, in general, purely numeric hashes seem to be scarce, it wasn't possible to add such a test case.
Therefore, let's go with it as it is. In the code, I added a comment with the link to the issue on php-src that Tom created.
|
Thanks, @tomdrissen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use strcmp instead of spaceship operator to prevent some weird behaviour when comparing hashes with more than 16 characters, see issue #71 .