Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default branch instead of master for .doctrine-project.json #356

Merged
merged 6 commits into from
Oct 19, 2020
Merged

Use default branch instead of master for .doctrine-project.json #356

merged 6 commits into from
Oct 19, 2020

Conversation

SenseException
Copy link
Member

@SenseException SenseException commented Aug 12, 2020 •
edited
Loading

In order for the release workflow and changing branch names, this PR introduces fetching the .doctrine-project.json infos of each repository from the default branch instead of master.

Repositories that need to move the website config .doctrine-project.json to the default branch:

  • annotations
  • cache
  • coding-standard
  • collections
  • common (still on master)
  • couchdb-client (still on master)
  • couchdb-odm (still on master)
  • dbal
  • doctrine1 (still on master)
  • DoctrineBundle
  • DoctrineCacheBundle (still on master)
  • DoctrineMigrationsBundle
  • DoctrineMongoDBBundle
  • DoctrineORMModule (still on master)
  • event-manager
  • inflector
  • instantiator
  • lexer (still on master)
  • migrations
  • mongodb (still on master)
  • mongodb-odm (still on master)
  • orientdb-odm (still on master)
  • orm
  • persistence
  • phpcr-odm (still on master)
  • reflection
  • rst-parser (still on master)
  • skeleton-mapper
  • all PRs got merged

@SenseException
Copy link
Member Author

There currently seems to be an invalid Github token that breaks the build. Because I don't have access to administer the Travis build and in favour of Github actions, There will be a new PR migrating out website build to Github actions. After the migration to Github actions, this draft can be finished as a PR.

@SenseException SenseException mentioned this pull request Sep 9, 2020
Merged
@SenseException
Copy link
Member Author

The build with the default-branch seems to work now. The build is failing because the website files of the current default branches have outdated branch names.

In the next days I'll create PRs to move the doctrine-website config from the master branches into the default branches. After all supported repositories by the website are covered, I'll change my draft into a PR and then it can be reviewed.

SenseException added a commit to doctrine/dbal that referenced this pull request Sep 27, 2020
@SenseException
Move website config to default branch
ec4caf4 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
@SenseException SenseException mentioned this pull request Sep 27, 2020
Merged
SenseException added a commit to doctrine/orm that referenced this pull request Sep 27, 2020
@SenseException
Move website config to default branch
a89b96e 
Adds the website config to be compatible with the doctrine/doctrine-website#356 changes
@SenseException SenseException mentioned this pull request Sep 27, 2020
Merged
SenseException added a commit to doctrine/annotations that referenced this pull request Sep 27, 2020
@SenseException
Move website config to default branch
700c1b6 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
@SenseException SenseException mentioned this pull request Sep 27, 2020
Merged
SenseException added a commit to doctrine/cache that referenced this pull request Sep 27, 2020
@SenseException
Move website config to default branch
9bfb7ff 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
@SenseException SenseException mentioned this pull request Sep 27, 2020
Merged
SenseException added a commit to doctrine/coding-standard that referenced this pull request Sep 27, 2020
@SenseException
Move website config to default branch
8e3612e 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
@SenseException SenseException mentioned this pull request Sep 27, 2020
Merged
SenseException added a commit to doctrine/collections that referenced this pull request Sep 27, 2020
@SenseException
Move website config to default branch
13ea230 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
@SenseException SenseException mentioned this pull request Sep 27, 2020
Merged
SenseException added a commit to doctrine/DoctrineBundle that referenced this pull request Sep 27, 2020
@SenseException
Move website config to default branch
e81f347 
Adds the website config to be compatible with the doctrine/doctrine-website#356 changes
@SenseException SenseException mentioned this pull request Sep 27, 2020
Merged
SenseException added a commit to doctrine/DoctrineMigrationsBundle that referenced this pull request Sep 27, 2020
@SenseException
Move website config to default branch
0337aac 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
@SenseException SenseException mentioned this pull request Sep 27, 2020
Merged
SenseException added a commit to doctrine/DoctrineMongoDBBundle that referenced this pull request Sep 27, 2020
@SenseException
Move website config to default branch
421d20f 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
@SenseException SenseException mentioned this pull request Sep 27, 2020
Merged
SenseException added a commit to doctrine/dbal that referenced this pull request Sep 28, 2020
@SenseException
Move website config to default branch
4bf867f 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
greg0ire pushed a commit to doctrine/DoctrineMongoDBBundle that referenced this pull request Sep 29, 2020
@SenseException @greg0ire
Move website config to default branch
8a0e1ab 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
SenseException added a commit to doctrine/event-manager that referenced this pull request Oct 1, 2020
@SenseException
Move website config to default branch
7d9d9a3 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
@SenseException SenseException mentioned this pull request Oct 1, 2020
Merged
SenseException added a commit to doctrine/inflector that referenced this pull request Oct 1, 2020
@SenseException
Move website config to default branch
84f7c86 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
SenseException added a commit to doctrine/migrations that referenced this pull request Oct 1, 2020
@SenseException
Move website config to default branch
23eb5df 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
@SenseException SenseException mentioned this pull request Oct 1, 2020
Merged
SenseException added a commit to doctrine/persistence that referenced this pull request Oct 1, 2020
@SenseException
Move website config to default branch
18c25e7 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
@SenseException SenseException mentioned this pull request Oct 1, 2020
Merged
SenseException added a commit to doctrine/orm that referenced this pull request Oct 2, 2020
@SenseException
Move website config to default branch (#8287)
bb64fc9 
Adds the website config to be compatible with the doctrine/doctrine-website#356 changes
SenseException added a commit to doctrine/reflection that referenced this pull request Oct 3, 2020
@SenseException
Move website config to default branch
4f143d5 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
@SenseException SenseException mentioned this pull request Oct 3, 2020
Merged
SenseException added a commit to doctrine/skeleton-mapper that referenced this pull request Oct 3, 2020
@SenseException
Move website config to default branch
c3775a8 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
@SenseException SenseException mentioned this pull request Oct 3, 2020
Merged
@SenseException
Copy link
Member Author

All supported projects are covered with Pull Requests. Some of the projects are still on master, which means there is currently no need for a PR as long as it stays on master. If these projects change their default branch, a PR will be needed for .doctrine-project.json. The worst case scenario for a changed default branch without changing this file is, that the .doctrine-project.json is outdated to a point where it can break the website build.

SenseException added a commit to doctrine/inflector that referenced this pull request Oct 5, 2020
@SenseException
Move website config to default branch
f6b90bc 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
l-vo pushed a commit to l-vo/orm that referenced this pull request Oct 11, 2020
@SenseException @l-vo
Move website config to default branch (doctrine#8287)
eab5fc4 
Adds the website config to be compatible with the doctrine/doctrine-website#356 changes
l-vo pushed a commit to l-vo/orm that referenced this pull request Oct 11, 2020
@SenseException @l-vo
Move website config to default branch (doctrine#8287)
3c0a2a1 
Adds the website config to be compatible with the doctrine/doctrine-website#356 changes
SenseException added a commit to doctrine/coding-standard that referenced this pull request Oct 14, 2020
@SenseException
Move website config to default branch
30863ee 
Adapts the website config to be compatible with the doctrine/doctrine-website#356 changes
@SenseException SenseException marked this pull request as ready for review October 15, 2020 18:46
@SenseException SenseException merged commit 78c3b96 into master Oct 19, 2020
@SenseException SenseException deleted the default-branch branch October 19, 2020 17:04
SenseException added a commit that referenced this pull request Nov 1, 2020
@SenseException
Skip zero releases without branch name
737a53e 
Since the default branch feature of #356 was merged, it can't
be assumed that a master branch exists for the target
repository.
@SenseException SenseException mentioned this pull request Nov 1, 2020
Merged
SenseException added a commit that referenced this pull request Nov 2, 2020
@SenseException
Skip zero releases without branch name
c5b3c59 
Since the default branch feature of #356 was merged, it can't
be assumed that a master branch exists for the target
repository.
SenseException added a commit that referenced this pull request Nov 2, 2020
@SenseException
Skip zero releases without branch name
2a4c186 
Since the default branch feature of #356 was merged, it can't
be assumed that a master branch exists for the target
repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SenseException @greg0ire