Add return to removeMethodTemplate #1407
Conversation
|
Hello, thank you for creating this pull request. I have automatically opened an issue http://www.doctrine-project.org/jira/browse/DDC-3734 We use Jira to track the state of pull requests and the versions they got |
|
Why would that be required? |
|
I want to know whether the item was deleted. |
|
@aivus can you then also update the docblock as per the |
|
|
|
@Ocramius should I do anything else? |
| @@ -277,10 +277,12 @@ public function <methodName>(<methodTypeHint>$<variableName>) | |||
| * <description> | |||
| * | |||
| * @param <variableType> $<variableName> | |||
| * | |||
| * @return boolean TRUE if this collection contained the specified element, FALSE otherwise. | |||
There was a problem hiding this comment.
From a PSR-5 compat perspective, this should be bool not boolean.
There was a problem hiding this comment.
Also PSR-5 is draft. I'm not sure about change boolean to bool. Is it required?
There was a problem hiding this comment.
I don't care tbh, was just nitpicking because there was a PR about this kinda thing recently...
|
Might be nice to have a regression test for this here |
Add tests for return types for addXxx() and removeXxx() methods
|
PR updated, tests added. |
|
@Ocramius PR is ready. Please, review when you can. |
Add return to removeMethodTemplate
|
@aivus thanks! |
I think we should return result of remove operation