Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return to removeMethodTemplate #1407

Merged
merged 2 commits into from
Nov 7, 2015
Merged

Add return to removeMethodTemplate #1407

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a98f03
Add return to removeMethodTemplate
aivus May 13, 2015
60b80c9
Add phpdoc tests for addXxx() and removeXxx() methods
aivus Oct 17, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/Doctrine/ORM/Tools/EntityGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,10 +277,12 @@ public function <methodName>(<methodTypeHint>$<variableName>)
* <description>
*
* @param <variableType> $<variableName>
*
* @return boolean TRUE if this collection contained the specified element, FALSE otherwise.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a PSR-5 compat perspective, this should be bool not boolean.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get it from https://github.com/doctrine/collections/blob/6c1e4eef75f310ea1b3e30945e9f06e652128b8a/lib/Doctrine/Common/Collections/Collection.php#L98

Also PSR-5 is draft. I'm not sure about change boolean to bool. Is it required?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't care tbh, was just nitpicking because there was a PR about this kinda thing recently...

*/
public function <methodName>(<methodTypeHint>$<variableName>)
{
<spaces>$this-><fieldName>->removeElement($<variableName>);
<spaces>return $this-><fieldName>->removeElement($<variableName>);
}';

/**
Expand Down