-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not ship docs #21
do not ship docs #21
Conversation
I'd say that docs should very much live in the distribution... |
Most of the libraries are excluding them and most of the doctrine libraries, too |
I'm thinking of the dozens of times where I wish I had a documentation that was on par with the downloaded library. Considering how little overhead the docs take (compared to tests, for example), I'd rather avoid this change, and even revert it for other Doctrine projects doing this. |
@Ocramius they will end up in production too… I think the archives should be production ready, devs that want docs and tests can use |
Yes, and I had a similar debate for tests: tests should not be in distribution because they are a lot, and they aren't usable anyway in that state. Docs are different: docs are useful and aren't that many files at all. Exactly like |
People that really do not want docs that might have big images in production can have a build step that deletes docs I guess… |
I can only imagine this to be a very marginal problem for docker environments, and then just don't use a language that ships files as main distribution mechanism? |
It's probably OK to ship docs:
|
Agree with shipping docs - shall we close this, doctrine/common#864 and doctrine/cache#298 and instead make sure docs are not excluded from archives? |
Shall I provide a PR against
master
, too?