-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against PHP 8.0 #33
Conversation
I was about to say the same 😄 No worries, I'll start with that first, then. |
@greg0ire I can probably copy most of the GitHub Actions logic from any repository that is already migrated, but is there some "reference" repository which I should use as the authoritative configuration? https://github.com/doctrine/orm/tree/2.7/.github/workflows for example? |
Yes exactly 👍 You will have to drop Psalm if it is not in use here, and there I already set up the automatic releases workflow, I believe otherwise Github Actions will not show up in this PR, they only seem to show up if there is already at least one Github Action. I'm doing a similar PR on doctrine/lexer#48 as an additional guidance. |
doctrine/coding-standard ^8.0 is the first version to support PHP 8.
I dropped the 2 commits that cancel each other out, it looks great now! |
Thanks a lot @nicwortel ! |
See doctrine/migrations#980 (comment), https://github.com/orgs/doctrine/projects/7#card-50248429.
Blocked by #34