Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against PHP 8.0 #33

Merged
merged 5 commits into from
Dec 4, 2020
Merged

Test against PHP 8.0 #33

merged 5 commits into from
Dec 4, 2020

Conversation

nicwortel
Copy link
Contributor

@nicwortel nicwortel commented Dec 1, 2020

@greg0ire
Copy link
Member

greg0ire commented Dec 1, 2020

Well… I think you will have to attempt migrating to Github Actions directly:

Screenshot_2020-12-01 doctrine event-manager - Travis CI

@nicwortel
Copy link
Contributor Author

nicwortel commented Dec 1, 2020

Well… I think you will have to attempt migrating to Github Actions directly:

I was about to say the same 😄

No worries, I'll start with that first, then.

@nicwortel
Copy link
Contributor Author

@greg0ire I can probably copy most of the GitHub Actions logic from any repository that is already migrated, but is there some "reference" repository which I should use as the authoritative configuration? https://github.com/doctrine/orm/tree/2.7/.github/workflows for example?

@greg0ire
Copy link
Member

greg0ire commented Dec 1, 2020

Yes exactly 👍 You will have to drop Psalm if it is not in use here, and there I already set up the automatic releases workflow, I believe otherwise Github Actions will not show up in this PR, they only seem to show up if there is already at least one Github Action. I'm doing a similar PR on doctrine/lexer#48 as an additional guidance.

composer.json Outdated Show resolved Hide resolved
@nicwortel nicwortel marked this pull request as ready for review December 4, 2020 17:26
@nicwortel nicwortel requested a review from greg0ire December 4, 2020 17:59
@greg0ire
Copy link
Member

greg0ire commented Dec 4, 2020

I dropped the 2 commits that cancel each other out, it looks great now!

@greg0ire greg0ire merged commit 05ffbf8 into doctrine:1.1.x Dec 4, 2020
@greg0ire
Copy link
Member

greg0ire commented Dec 4, 2020

Thanks a lot @nicwortel !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants