Merge pull request #419 from mikeSimonson/refactor-mark-version

refactoring the mark version migrated / not migrated code
doctrine · Jan 13, 2016 · 58b4f5c · 58b4f5c
2 parents fdcb4e0 + 1de8172
commit 58b4f5c
Showing 1 changed file with 12 additions and 6 deletions.
diff --git a/lib/Doctrine/DBAL/Migrations/Version.php b/lib/Doctrine/DBAL/Migrations/Version.php
@@ -153,20 +153,26 @@ public function isMigrated()
 
     public function markMigrated()
     {
+        $this->markVersion('up');
+    }
+
+    private function markVersion($direction)
+    {
+        if ($direction == 'up') {
+            $action = 'insert';
+        } else {
+            $action = 'delete';
+        }
         $this->configuration->createMigrationTable();
-        $this->connection->insert(
+        $this->connection->$action(
             $this->configuration->getMigrationsTableName(),
             [$this->configuration->getMigrationsColumnName() => $this->version]
         );
     }
 
     public function markNotMigrated()
     {
-        $this->configuration->createMigrationTable();
-        $this->connection->delete(
-            $this->configuration->getMigrationsTableName(),
-            [$this->configuration->getMigrationsColumnName() => $this->version]
-        );
+        $this->markVersion('down');
     }
 
     /**