Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doctrine/dbal 3 support #1141

Closed
weaverryan opened this issue Mar 31, 2021 · 12 comments
Closed

doctrine/dbal 3 support #1141

weaverryan opened this issue Mar 31, 2021 · 12 comments

Comments

@weaverryan
Copy link
Contributor

Feature Request

Q A
New Feature yes
RFC yes
BC Break no

Summary

Apologies if I've missed some discussion somewhere! Is there any blocker for making a PR to add doctrine/dbal 3 support?

Thanks!

@greg0ire
Copy link
Member

I don't think so, you can give it a try if you want IMO 👍

@greg0ire
Copy link
Member

In fact, I just gave it a try, and there is no point until the ORM supports DBAL 3.

@PowerKiKi
Copy link
Contributor

Do you mean that it is technically impossible to do, or that even if we did it would not really be useful ?

What blocker did you see ?

@greg0ire
Copy link
Member

There is a dev dependency on the ORM which prevents installing DBAL 3, so you cannot run the test suite with it.

@scaytrase
Copy link

Any updates on this? dbal 3 seems useless on most of our projects because we have migrations and migrations bundle preventing installation of that version.

@PowerKiKi
Copy link
Contributor

This issue is blocked by https://github.com/doctrine/orm/projects/5

@greg0ire
Copy link
Member

If you feel that blocker is important, you can work on removing it by adding a CI job that does composer remove doctrine/orm then runs the tests suite but skips tests involving the orm

@derrabus
Copy link
Member

ORM 2.10.x-dev allows the installation of DBAL 3. The blocker should be gone, I guess.

@gjuric
Copy link

gjuric commented Oct 3, 2021

ORM now supports DBAL 3, any chance somebody is working on this?

@derrabus
Copy link
Member

derrabus commented Oct 3, 2021

@gjuric Did you see #1198?

@gjuric
Copy link

gjuric commented Oct 3, 2021

Saw it, this was just a little nudge to make it happen without putting pressure on anybody :)

@goetas
Copy link
Member

goetas commented Nov 8, 2021

implemented in #1198

@goetas goetas closed this as completed Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants