Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBAL v3 compatibility #1198

Merged
merged 15 commits into from
Oct 14, 2021
Merged

DBAL v3 compatibility #1198

merged 15 commits into from
Oct 14, 2021

Conversation

goetas
Copy link
Member

@goetas goetas commented Sep 17, 2021

Q A
Type feature
BC Break no
Fixed issues #1141 (comment)

@goetas goetas force-pushed the dbal3 branch 2 times, most recently from 88fddda to 388478e Compare September 17, 2021 05:04
@goetas
Copy link
Member Author

goetas commented Sep 19, 2021

blocked by doctrine/dbal#4800

@derrabus derrabus mentioned this pull request Oct 3, 2021
Closed
@dpfaffenbauer
Copy link

doctrine/dbal#4811 fixed it right? anything I can do to help here? @goetas

@brusch brusch mentioned this pull request Oct 5, 2021
Closed
@goetas
Copy link
Member Author

goetas commented Oct 9, 2021

Does anyone know a better way to test the dbal v3 and v2 with phpstan without duplicating the phpstan config file?

@mbabker
Copy link

mbabker commented Oct 10, 2021

Does anyone know a better way to test the dbal v3 and v2 with phpstan without duplicating the phpstan config file?

Take a look at how it's handled in the ORM.

@goetas goetas changed the title WIP, dbal3 DBAL v3 compatibility Oct 13, 2021
@goetas goetas marked this pull request as ready for review October 13, 2021 07:11
@goetas goetas requested a review from greg0ire October 13, 2021 07:11
@derrabus derrabus closed this Oct 13, 2021
@derrabus derrabus reopened this Oct 13, 2021
@derrabus
Copy link
Member

CI has failed because getcomposer.org was down this morning. I've restarted it.

greg0ire
greg0ire reviewed Oct 13, 2021
View reviewed changes
composer.json Outdated Show resolved Hide resolved
@greg0ire
Copy link
Member

Should we squash everything or are there commits in there you would like to keep independent from the rest?

@goetas goetas merged commit 87902d4 into 3.3.x Oct 14, 2021
@goetas goetas deleted the dbal3 branch October 14, 2021 20:55
@goetas goetas added this to the 3.3.0 milestone Oct 14, 2021
@brusch
Copy link

brusch commented Oct 15, 2021

Thanks a lot guys!
@goetas is there any eta for the 3.3.0 release?

@brusch brusch mentioned this pull request Oct 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@goetas @dpfaffenbauer @mbabker @derrabus @greg0ire @brusch