Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Schema::getTableNames() #4811

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Fix Schema::getTableNames() #4811

merged 1 commit into from
Sep 27, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Sep 22, 2021 •
edited
Loading

Q A
Type bug
BC Break no

Closes #4800.

@morozov morozov added this to the 3.1.3 milestone Sep 22, 2021
@morozov morozov force-pushed the schema-get-table-names branch from e343550 to be2441f Compare September 22, 2021 19:55
@morozov morozov force-pushed the schema-get-table-names branch from be2441f to 3aa0227 Compare September 22, 2021 20:09
@morozov morozov marked this pull request as ready for review September 22, 2021 20:41
@morozov morozov requested a review from greg0ire September 22, 2021 20:42
@morozov morozov mentioned this pull request Sep 22, 2021
Closed
@goetas
Copy link
Member

goetas commented Sep 24, 2021 •
edited
Loading

Two questions,

  1. shouldn't this branch contain also the failing test i've added? (eventually adjusted)
  2. you were mentioning to deprecate getTableNames (that was looking a reasonable choice to me), did you change your mind about it? or it can be done in a separate PR?

@morozov
Copy link
Member Author

morozov commented Sep 24, 2021

shouldn't this branch contain also the failing test i've added? (eventually adjusted)

It should but the actual fully-qualified name is different on different platforms, so making the test pass requires effectively duplicating the code being tested. You can try it in your own branch to see the failures.

you were mentioning to deprecate getTableNames (that was looking a reasonable choice to me), did you change your mind about it? or it can be done in a separate PR?

It's done in #4812. The current PR goes into the next patch release as it's a bugfix, that one goes into the next minor as it's a deprecation.

@morozov morozov merged commit 33c2118 into doctrine:3.1.x Sep 27, 2021
@morozov morozov deleted the schema-get-table-names branch September 27, 2021 15:39
@morozov morozov mentioned this pull request Sep 28, 2021
Merged
1 task
@dpfaffenbauer dpfaffenbauer mentioned this pull request Oct 5, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Bug Schema
Projects
None yet
Milestone
3.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@morozov @goetas @greg0ire