Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade phpunit #1072

Merged
merged 2 commits into from
Nov 8, 2020
Merged

Upgrade phpunit #1072

merged 2 commits into from
Nov 8, 2020

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Nov 8, 2020

Q A
Type improvement
BC Break no
Fixed issues n/a

Summary

Recent versions are required for PHP 8, I don't want to make the PHP 8 PR too big.

goetas
goetas approved these changes Nov 8, 2020
View reviewed changes
Copy link
Member

@goetas goetas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of very simple changes, so is ok for me!

@greg0ire greg0ire requested a review from goetas November 8, 2020 19:28
@greg0ire greg0ire merged commit 9b69ae5 into doctrine:2.3.x Nov 8, 2020
@greg0ire greg0ire added this to the 2.3.1 milestone Dec 5, 2020
@greg0ire greg0ire deleted the upgrade-phpunit branch December 5, 2020 19:16
@github-actions github-actions bot mentioned this pull request Dec 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goetas goetas Awaiting requested review from goetas

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@greg0ire @goetas