Address MasterSlaveConnection rename #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
commented
Dec 2, 2020
| * simplest to set up for. | ||
| * | ||
| * @see https://github.com/doctrine/migrations/issues/336 | ||
| */ |
There was a problem hiding this comment.
I copy/pasted the comment of the method above.
MasterSlaveConnection has been deprecated in favor of PrimaryReadReplicaConnection, which it extends before being removed in DBAL 3. This ensure both cases are handled when it comes to making sure we connect to the primary, while not bumping the requirement to doctrine/dbal 2.11 (which requires PHP 7.3, although subsequent version might restore compatibility with 7.1).
greg0ire
force-pushed
the
address-master-slave-rename
branch
from
69300c5 to
dbbd7b3
Compare
greg0ire
commented
Dec 2, 2020
| @@ -17,6 +17,8 @@ parameters: | |||
| - '~^Parameter #1 \$files of method Doctrine\\Migrations\\Finder\\Finder::loadMigrationClasses\(\) expects array<string>, array<int, string\|false> given\.\z~' | |||
| - '~^Class Doctrine\\Migrations\\Tests\\DoesNotExistAtAll not found\.\z~' | |||
| - '~^Call to method getVersion\(\) of deprecated class PackageVersions\\Versions\.$~' | |||
| # Drop when bumping to doctrine/dbal 2.11+ | |||
| - '~^.*PrimaryReadReplicaConnection.*$~' | |||
There was a problem hiding this comment.
phpstan is ran on 7.1, which prevents installing a recent enough version of doctrine/dbal, and generates quite a few errors because the class does not exist. The errors can be seen (for now) at https://github.com/doctrine/migrations/runs/1489165823?check_suite_focus=true
goetas
approved these changes
Dec 4, 2020
SenseException
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
MasterSlaveConnection has been deprecated in favor of
PrimaryReadReplicaConnection, which it extends before being removed in
DBAL 3. This ensure both cases are handled when it comes to making sure
we connect to the primary, while not bumping the requirement to
doctrine/dbal 2.11 (which requires PHP 7.3, although subsequent version
might restore compatibility with 7.1).