Implement platform-aware schema comparison #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
commented
Jan 12, 2022
| ->method('getMigrateFromSql') | ||
| ->with($toSchema, $this->platform) | ||
| ->willReturn(['UPDATE table SET value = 1']); | ||
| } |
There was a problem hiding this comment.
I tried to find a way to abide by "don't mock what you don't own" and reduce the big amount of mocking in this test, and gave up… I think it should be reworked, but I'm not sure how.
greg0ire
force-pushed
the
platform-aware-comparison
branch
3 times, most recently
from
3edd76c
to
9e44edc
Compare
This should fix many bugs because it eliminates a lot of false positive and false negative diffs.
greg0ire
force-pushed
the
platform-aware-comparison
branch
from
9e44edc
to
5bf68e9
Compare
greg0ire
commented
Jan 12, 2022
|
|
||
| $upSql = isset($comparator) ? | ||
| $comparator->compareSchemas($fromSchema, $toSchema)->toSql($this->platform) : | ||
| $fromSchema->getMigrateToSql($toSchema, $this->platform); |
There was a problem hiding this comment.
At first, I tried inlining the contents of this method to avoid the deprecation, but then I could no longer mock anything.
derrabus
approved these changes
Jan 12, 2022
morozov
approved these changes
Jan 12, 2022
This was referenced Jan 16, 2022
This was referenced Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix many bugs because it eliminates a lot of false positive
and false negative diffs.
Closes #1227