Insert/delete sql queries for metadata table during dry-run and write-sql #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
Jul 18, 2022
lib/Doctrine/Migrations/Metadata/Storage/TableMetadataStorage.php
Outdated
Show resolved
Hide resolved
lib/Doctrine/Migrations/Metadata/Storage/TableMetadataStorage.php
Outdated
Show resolved
Hide resolved
greg0ire
reviewed
Jul 19, 2022
lib/Doctrine/Migrations/Metadata/Storage/TableMetadataStorage.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/Migrations/Tests/Metadata/Storage/TableMetadataStorageTest.php
Outdated
Show resolved
Hide resolved
tests/Doctrine/Migrations/Tests/Metadata/Storage/TableMetadataStorageTest.php
Show resolved
Hide resolved
greg0ire
reviewed
Jul 20, 2022
wiistriker
commented
Jul 20, 2022
|
any news on this? |
greg0ire
approved these changes
Jul 25, 2022
|
any news on this? |
|
No reviews… I should have some time to merge and release this this afternoon. |
|
Is there any options to have this changes in 3.0 version? |
Nope, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Db user in my app doesn't have CREATE, ALTER query permissions so i cant run my migrations from php. Instead of this i write all necessary sql queries to file and run it from another user. After upgrading doctrine migrations to newer version i faced with issue, that resulted sql file doesnt contain insert/delete queries for meta table (doctrine_migration_versions). Very frustrating to insert this information myself so i ended up with this solution.
Such issue already been described in #1082
Summary
I am not sure about TableMetadataStorage::complete method. I see you using Connection::insert, Connection::delete methods. It seems like we need to replace it with Connection::execute and use already generated queries