Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for silencing errors about DDL in transactions #1300

Open
wants to merge 1 commit into
base: 4.0.x
Choose a base branch
from

Conversation

greg0ire
Copy link
Member

@greg0ire greg0ire commented Jan 11, 2023

I hesitated between this and removing the transaction helper entirely, but I think this solution will result in less support for us. Let me know if you think I should remove the transaction helper.

@SenseException
Copy link
Member

If the helper class is kept in 4.0, it can only be removed in a 5.0 release, right? It doesn't seem to be widely in use now.

@greg0ire
Copy link
Member Author

I think the choice is between removing it in 4.0, or keeping it forever, for DX reasons.

@derrabus
Copy link
Member

The method naming is odd now. The names end with IfInTransaction which suggests that I can also safely call the method without an active transaction. But that's not the case anymore.

@greg0ire
Copy link
Member Author

Ok, I'll switch to just commit and rollback then.

I hesitated between this and removing the transaction helper entirely,
but I think this solution will result in less support for us.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants