Fixed all-or-nothing console input value determination.
#1308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug that was introduced in doctrine#1296 where the configuration value of allOrNothing got set to true if the command didn't have an all-or-nothing option. Now the value is set from input options only if the command that is being executed has an `all-or-nothing` option.
agustingomes
approved these changes
Jan 17, 2023
greg0ire
approved these changes
Jan 17, 2023
|
Thanks @e-jevdokimovs ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a bug that was introduced in #1296 where the configuration value of
MigratorConfiguration::allOrNothinggot set totrueif the command didn't have anall-or-nothingoption. Now the value is set from input options only if the command that is being executed has anall-or-nothingoption.