build: Fix cleanup of the backup composer lock file #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trap function was registered as the last bash instruction and as a result was not executed if anything failed before, e.g. the composer update command or building the PHAR itself. In the event the build PHAR script fails, the temporary backup composer.lock file may be created and not removed.
theofidry
force-pushed
the
buid/gitignore
branch
from
a7ee098 to
3af121d
Compare
greg0ire
approved these changes
Mar 15, 2023
|
Thanks @theofidry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trap function was registered as the last bash instruction and as a result was not executed if anything failed before, e.g. the composer update command or building the PHAR itself.
In the event the build PHAR script fails, the temporary backup composer.lock file may be created and not removed.
Also add the backup composer.lock file to the gitignore for good measure.