fix: Allow enum param types: ArrayParameterType and ParameterType #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes doctrine#1407 A bit lame fix, but it looks like we did not really use other int types before anyway With this change we can use DBAL v4 new enum types: `ArrayParameterType` and `ParameterType`. Bumping version of DBAL to 3.6 as before that `ArrayParameterType` did not exist.
michalbundyra
changed the title
|
Thank you. Please add a test that covers your change. |
derrabus
reviewed
Mar 6, 2024
| @@ -53,7 +55,7 @@ public function formatParameters(array $params, array $types): string | |||
| return sprintf('with parameters (%s)', implode(', ', $formattedParameters)); | |||
| } | |||
|
|
|||
| private function formatParameter(mixed $value, string|int $type): string|int|bool|float|null | |||
| private function formatParameter(mixed $value, string|int|ArrayParameterType|ParameterType $type): string|int|bool|float|null | |||
There was a problem hiding this comment.
I wonder if we should change the type to mixed. After all, the method discards any value that is not a string anyway.
There was a problem hiding this comment.
@derrabus pushed - if we ok with mixed, then I can even change back the bump in composer.json, but then we would not have a test case for ArrayParameterType as it does not exist in DBAL 3.5
derrabus
reviewed
Mar 6, 2024
tests/Doctrine/Migrations/Tests/InlineParameterFormatterTest.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Alexander M. Turek <me@derrabus.de>
derrabus
approved these changes
Mar 6, 2024
|
@derrabus thanks! |
|
Thank you! |
derrabus
added a commit
that referenced
this pull request
Mar 6, 2024
* 3.7.x: fix: Allow enum param types: ArrayParameterType and ParameterType (#1408)
|
Let's do the bump in #1411. |
derrabus
added a commit
to derrabus/migrations
that referenced
this pull request
Mar 11, 2024
* 3.8.x: Raise PHPStan level to 8 (doctrine#1409) Remove unused paramaters from DiffCommand and VersionCommand (doctrine#1386) Simplify InlineParameterFormatterTest (doctrine#1411) fix: Allow enum param types: ArrayParameterType and ParameterType (doctrine#1408)
derrabus
added a commit
to derrabus/migrations
that referenced
this pull request
Mar 11, 2024
* 3.8.x: Raise PHPStan level to 8 (doctrine#1409) Remove unused paramaters from DiffCommand and VersionCommand (doctrine#1386) Simplify InlineParameterFormatterTest (doctrine#1411) fix: Allow enum param types: ArrayParameterType and ParameterType (doctrine#1408)
derrabus
added a commit
to derrabus/migrations
that referenced
this pull request
Mar 11, 2024
* 3.8.x: Fix CS Raise PHPStan level to 8 (doctrine#1409) Remove unused paramaters from DiffCommand and VersionCommand (doctrine#1386) Simplify InlineParameterFormatterTest (doctrine#1411) fix: Allow enum param types: ArrayParameterType and ParameterType (doctrine#1408)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1407
A bit lame fix, but it looks like we did not really use other int types before anyway
With this change we can use DBAL v4 new enum types:
ArrayParameterTypeandParameterType.Bumping version of DBAL to 3.6 as before thatArrayParameterTypedid not exist.Just to note - the problem itself is ONLY with DBAL 4.0+ as on 3.6 these types were classes with constants, not enums.