Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test logger implementations #1450

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

derrabus
Copy link
Member

Q A
Type improvement
BC Break no
Fixed issues N/A

Summary

I'd like to leverage the fig/log-test package so we don't have to invent our own mock implementations of the psr/log interfaces.

@derrabus derrabus added the Tests label Aug 26, 2024
@derrabus derrabus added this to the 3.9.0 milestone Aug 26, 2024
@derrabus derrabus requested a review from greg0ire August 26, 2024 09:15
@derrabus derrabus force-pushed the improvement/test-logger-impl branch from 1b05b36 to f7854f3 Compare August 26, 2024 09:21
@derrabus derrabus force-pushed the improvement/test-logger-impl branch from f7854f3 to 3dbd326 Compare August 26, 2024 09:25
@greg0ire
Copy link
Member

greg0ire commented Aug 26, 2024

You're only touching tests here, so why not target 3.8.x? We don't want new tests to use the previous way.

@derrabus derrabus mentioned this pull request Aug 26, 2024
@derrabus
Copy link
Member Author

Good point, I'm rebasing.

@derrabus derrabus force-pushed the improvement/test-logger-impl branch from 3dbd326 to 2cd05b3 Compare August 26, 2024 09:50
@derrabus derrabus changed the base branch from 3.9.x to 3.8.x August 26, 2024 09:50
@derrabus derrabus modified the milestones: 3.9.0, 3.8.1 Aug 26, 2024
@derrabus derrabus closed this Aug 26, 2024
@derrabus derrabus reopened this Aug 26, 2024
@derrabus derrabus merged commit a0eb4e1 into doctrine:3.8.x Aug 26, 2024
12 checks passed
@derrabus derrabus deleted the improvement/test-logger-impl branch August 26, 2024 10:41
@derrabus derrabus mentioned this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants