Resolves #939 replaced single quotes with nowdoc #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamil-karkus
commented
Nov 29, 2024
kamil-karkus
commented
| Q | A |
|---|---|
| Type | improvement |
| BC Break | no |
| Fixed issues | #939 |
|
Thanks for working on this. It seems there are CI jobs failing. Please take a look at this guide for more on how to handle those. |
kamil-karkus
force-pushed
the
3.8.x
branch
3 times, most recently
from
4e4f8c4 to
7b67927
Compare
|
@greg0ire thanks, I had to fix units. |
This comment was marked as resolved.
This comment was marked as resolved.
It makes it easier to write queries that contain quotes and single quotes, and to get syntactic coloration. Fixes doctrine#939
greg0ire
approved these changes
Nov 29, 2024
SenseException
approved these changes
Nov 29, 2024
|
Thanks @kamil-karkus !!! |
|
@greg0ire Thank you for taking care of this issue. I was planning to get back to it on Monday, following the guide you sent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.