Regression test #414
Merged
Regression test #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->connection->getDatabasePlatform()); | ||
| $this->schemaProvider = new LazySchemaDiffProvider(new LazyLoadingValueHolderFactory(), $schemaProvider); | ||
| $this->schemaProvider = $schemaProvider; | ||
| if(is_null($this->schemaProvider)) { |
There was a problem hiding this comment.
can it ever be null? the docblock states it can't...
There was a problem hiding this comment.
Does this
/** @var SchemaDiffProviderInterface */
private $schemaProvider;means that the property can never be null ?
It will never be null it's just the parameter of the constructor that is optional.
There was a problem hiding this comment.
Then it should state /** @var SchemaDiffProviderInterface|null */
There was a problem hiding this comment.
Does the new way of setting that property prevent the need for null in the docblock ?
mikeSimonson
force-pushed
the
regression-test
branch
from
8c724fa to
e6a2fe9
Compare
| $schemaProvider = new SchemaDiffProvider($this->connection->getSchemaManager(), | ||
| $this->connection->getDatabasePlatform()); | ||
| $this->schemaProvider = new LazySchemaDiffProvider(new LazyLoadingValueHolderFactory(), $schemaProvider); | ||
| if (!is_null($schemaProvider)) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.