Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Move Expected Exception #435

Merged
merged 1 commit into from
Feb 18, 2016
Merged

Fix: Move Expected Exception #435

merged 1 commit into from
Feb 18, 2016

Conversation

rcatlin
Copy link
Contributor

@rcatlin rcatlin commented Feb 18, 2016

  • Moves expectException() call in Unit Test after the call to getSqlConfiguration to ensure exception is thrown from call to getVersion as intended.

@rcatlin
Copy link
Contributor Author

rcatlin commented Feb 18, 2016

@stof review?

@stof
Copy link
Member

stof commented Feb 18, 2016

👍

@rcatlin rcatlin mentioned this pull request Feb 18, 2016
Merged
@rcatlin
Copy link
Contributor Author

rcatlin commented Feb 18, 2016

@stof Thank you!

stof added a commit that referenced this pull request Feb 18, 2016
@stof
Merge pull request #435 from rcatlin/fix/expect-exception-get-version
0074c94 
Fix: Move Expected Exception
@stof stof merged commit 0074c94 into doctrine:master Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcatlin @stof