Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update license to MIT. #659

Merged
merged 1 commit into from
May 16, 2018
Merged

Update license to MIT. #659

merged 1 commit into from
May 16, 2018

Conversation

jwage
Copy link
Member

@jwage jwage commented May 8, 2018

Fixes #623

@jwage jwage added this to the 2.0 milestone May 8, 2018
@jwage jwage self-assigned this May 8, 2018
@stof
Copy link
Member

stof commented May 9, 2018

We still need a few approvals, right ?

@jwage
Copy link
Member Author

jwage commented May 9, 2018

Yes, just preparing the PR ahead of time.

Majkl578
Majkl578 approved these changes May 16, 2018
View reviewed changes
Copy link
Contributor

@Majkl578 Majkl578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by all contributors: #623

alcaeus
alcaeus requested changes May 16, 2018
View reviewed changes
Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to change the license in composer.json as well.

@jwage jwage force-pushed the update-license branch from ed300a5 to ea94f79 Compare May 16, 2018 12:00
@jwage jwage merged commit 57b8db1 into master May 16, 2018
@jwage jwage deleted the update-license branch May 16, 2018 12:09
@stof
Copy link
Member

stof commented May 16, 2018

should we merge this in 1.x as well, so that both maintained branch are under the same license ? this would simplify the maintenance, as we would not need to accept LGPL contributions to 1.X and then asking contributors to accept moving them to MIT when applying the same fix in 2.0.

@jwage
Copy link
Member Author

jwage commented May 16, 2018

Yes

jwage added a commit that referenced this pull request May 16, 2018
@jwage
Merge pull request #659 from doctrine/update-license
c43891c 
Update license to MIT.
Conflicts:
	composer.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcaeus alcaeus alcaeus approved these changes

@Majkl578 Majkl578 Majkl578 approved these changes

Assignees

@jwage jwage

Labels
Improvement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jwage @stof @Majkl578 @alcaeus