Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Doctrine\Migrations\Migration to Doctrine\Migrations\Migrator #671

Merged
merged 1 commit into from
May 12, 2018
Merged

Rename Doctrine\Migrations\Migration to Doctrine\Migrations\Migrator #671

merged 1 commit into from
May 12, 2018

Conversation

jwage
Copy link
Member

@jwage jwage commented May 12, 2018

Q A
Type change
BC Break yes

Summary

Rename the Doctrine\Migrations\Migration class to Doctrine\Migrations\Migrator to. This name makes more sense for what it is doing and to differentiate between it and Doctrine\Migrations\AbstractMigration

@jwage jwage requested a review from Majkl578 May 12, 2018 01:22
@jwage jwage self-assigned this May 12, 2018
@jwage jwage added this to the 2.0 milestone May 12, 2018
@jwage jwage force-pushed the rename-migration branch 2 times, most recently from 3246cdf to 0b0d93d Compare May 12, 2018 02:23
localheinz
localheinz approved these changes May 12, 2018
View reviewed changes
Copy link
Contributor

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Majkl578
Majkl578 approved these changes May 12, 2018
View reviewed changes
Copy link
Contributor

@Majkl578 Majkl578 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to document it in upgrading.

@jwage jwage force-pushed the rename-migration branch from 0b0d93d to 20cbd1e Compare May 12, 2018 14:58
@jwage jwage merged commit 98f68eb into master May 12, 2018
@jwage jwage deleted the rename-migration branch May 12, 2018 15:05
@jwage jwage removed the BC Break label May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Majkl578 Majkl578 Majkl578 approved these changes

@localheinz localheinz localheinz approved these changes

Assignees

@jwage jwage

Labels
Improvement
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jwage @Majkl578 @localheinz