Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show more help text after generating a migration. #673

Merged
merged 1 commit into from
May 12, 2018

Conversation

jwage
Copy link
Member

@jwage jwage commented May 12, 2018

Q A
Type feature
BC Break no
Fixed issues #173

Summary

Improve the developer experience by showing more help text after generating a new migration.

cc @weaverryan

Output

$ ./migrations migrations:generate
Generated new migration class to "/data/doctrine/migration-test/lib/Doctrine/Test/Migrations/Version20180512034732.php"

To run just this migration for testing purposes, you can use migrations:execute --up 20180512034732

To revert the migration you can use migrations:execute --down 20180512034732

@jwage jwage added this to the 2.0 milestone May 12, 2018
$versionNumber
));

$output->writeln(sprintf(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of multiple consecutive calls to writeln(), and instead of prefixing messages with "\n", what do you think about passing an array of message strings (and empty strings for new lines) to writeln() instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

Copy link
Contributor

@localheinz localheinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jwage jwage force-pushed the dx-migration-generation branch from 8f9cd09 to e0825c5 Compare May 12, 2018 15:03
@jwage jwage force-pushed the dx-migration-generation branch from e0825c5 to d5bf6bb Compare May 12, 2018 15:10
@jwage jwage merged commit 77cd29d into master May 12, 2018
@jwage jwage deleted the dx-migration-generation branch May 12, 2018 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants