Implement all or nothing transaction strategy for migrations. #683
Conversation
jwage
force-pushed
the
all-or-nothing-migrations
branch
5 times, most recently
from
a18b89a to
9e23538
Compare
jwage
force-pushed
the
all-or-nothing-migrations
branch
2 times, most recently
from
19856c5 to
4c35bf1
Compare
| @@ -24,6 +24,7 @@ | |||
| </xs:simpleType> | |||
| </xs:element> | |||
| <xs:element type="xs:string" name="migrations-directory" minOccurs="0" maxOccurs="1"/> | |||
| <xs:element type="xs:string" name="all-or-nothing" minOccurs="0" maxOccurs="1"/> | |||
jwage
force-pushed
the
all-or-nothing-migrations
branch
13 times, most recently
from
146e747 to
ea336e8
Compare
jwage
force-pushed
the
all-or-nothing-migrations
branch
from
ea336e8 to
acbe335
Compare
| @@ -70,6 +70,8 @@ file like the following: | |||
|
|
|||
| <migrations-directory>/path/to/migrations/classes/DoctrineMigrations</migrations-directory> | |||
|
|
|||
| <all-or-nothing>1</all-or-nothing> | |||
|
|
||
| <migrations-directory>/path/to/migrations/classes/DoctrineMigrations</migrations-directory> | ||
|
|
||
| <all-or-nothing>true</all-or-nothing> |
There was a problem hiding this comment.
... here it is true.
Should be consistent
There was a problem hiding this comment.
The docs were updated and fixed at some point in the future. FYI, we take the string from the XML and pass it through this class https://github.com/doctrine/migrations/blob/master/lib/Doctrine/Migrations/Tools/BooleanStringFormatter.php here https://github.com/doctrine/migrations/blob/master/lib/Doctrine/Migrations/Configuration/XmlConfiguration.php#L89
|
|
||
| If you want your migrations to be all or nothing then you can configure your migrations behave that way. | ||
| This means when you executed multiple migrations in a row, the whole migration will be wrapped | ||
| in a single migration and if one of the migrations fails, the transaction will be rolled back. |
There was a problem hiding this comment.
wrapped in a single transaction
looks like a typo?
There was a problem hiding this comment.
Looks like it. Can you check if it still exists in master and record an issue to fix it if so?
There was a problem hiding this comment.
@jwage oh, didn't realize that the PR is so old 😅
The whole paragraph is gone in 2.0 and I couldn't find it in 1.8 either (that's where this PR landed).
So probably already fixed then. 👍
Sorry for the noise.
Summary
Implement all or nothing transaction strategy for migrations.