Fix command return type hints so they are consistent and match what S… #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ymfony API specifies.
Majkl578
reviewed
Jun 5, 2018
| @@ -47,7 +47,7 @@ protected function configure() : void | |||
| parent::configure(); | |||
| } | |||
|
|
|||
| public function execute(InputInterface $input, OutputInterface $output) : void | |||
| public function execute(InputInterface $input, OutputInterface $output) : ?int | |||
There was a problem hiding this comment.
The return types shouldn't be nullable, you never return null.
Also if upstream ever adds ?int return type, removing nullability is valid covariant change.
There was a problem hiding this comment.
I made it match what the Symfony console doc block has currently. You are correct that in our commands we never return null, so we could change this here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Working on updating DoctrineMigrationsBundle and I noticed the return type hints for the commands were not consistent and inline with what the Symfony console return type is defined as.