Use DateTimeImmutable instead of DateTime. #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Majkl578
approved these changes
Jan 3, 2019
greg0ire
approved these changes
Jan 3, 2019
| @@ -41,7 +41,7 @@ public function write( | |||
| array $queriesByVersion, | |||
| ?DateTimeInterface $now = null | |||
| ) : bool { | |||
| $now = $now ?? new DateTime(); | |||
| $now = $now ?? new DateTimeImmutable(); | |||
There was a problem hiding this comment.
Does it make sense to use new DateTimeImmutable('now', new DateTimeZone('UTC')); like above in Configuration.php? Can a timezone with daylight saving time be an issue here?
There was a problem hiding this comment.
Probably should be changed to match elsewhere. Practically I don't think it would ever cause an issue though.
There was a problem hiding this comment.
I think it needs good timing. But this is for another time and PR to find out.
There was a problem hiding this comment.
I will send another PR to fix that.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to conversation here #773 (comment)