Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sharding already in the migrations #866

Closed
wants to merge 121 commits into from
Closed

Implement sharding already in the migrations #866

wants to merge 121 commits into from

Conversation

goetas
Copy link
Member

@goetas goetas commented Nov 8, 2019

Q A
Type feature/improvement
BC Break yes
Fixed issues -

Summary

Implement sharding already in the migrations, no need for bundle

goetas added 30 commits October 23, 2019 13:15
@goetas
use multiple migrations directories and namespaces
fd99b38
@goetas
update more commands
12b6288
@goetas
increase version
81e3b4b
@goetas
allow custom sorting
564ce17
@goetas
executor
2c97ea6
@goetas
remove start migration
ba6494c
@goetas
value object comparison for versions
e7253d9
@goetas
adapted execute command
0f3f33a
@goetas
do not load from sub namespaces
643198f
@goetas
format migration state
881c40c
@goetas
start adapting tests
c7b7f74
@goetas
stricter execution result
0d4090b
@goetas
create MigratorConfigurationFactory
97894cc
@goetas
extract factory interface
cfbcb4d
@goetas
fix event dispatcher
b130cc3
@goetas
use configuration loaders, drop inheritance
b4bda42
@goetas
add config loader tests
8ac4757
@goetas
config tests
aa37721
@goetas
executor tests
200e3e5
@goetas
command tests
eccdc9a
@goetas
up to date command
d7f073f
@goetas
migrations repo tests
d8bccb0
@goetas
metadata tests
e01c482
@goetas
alias resolver tests
9aba11a
@goetas
factory test
dd6fa67
@goetas
cs and tests
eb239c1
@goetas
interface
bd24edf
@goetas
autocommit listener
2898e88
@goetas
migration plan calculator tests
d577200
@goetas
simplify code for migration plan calculator
46282d3
goetas added 24 commits October 23, 2019 13:19
@goetas
upgrade
a00fa06
@goetas
run cs on php 7.2
ffcf543
@goetas
windows tests
8fab0d0
@goetas
filesystem sorting is not relevant in the finder
45a028d
@goetas
migration plan execution is immutable
55ff179
@goetas
warn to not use registerMigrationInstance
97c868e
@goetas
regex finder accepts any class naming
79035fa
@goetas
do not allow invalid config keys
bc12a43
@goetas
array loader is a hard dependency for the other loaders
4c0029b
@goetas
no invalid keys are allowed
fadba6d
@goetas
refer to https://github.com/Roave/BackwardCompatibilityCheck instead …
3a50fc4 
…of having a long list
@goetas
classgenerator test
8e50943
@goetas
ensure there is always some metadata configuration set
9054023
@goetas
test minimal metadata configuration
599d9c4
@goetas
do not generate anymore empty down() methods, but fail instead
83fef4a
@goetas
ensure ExecutionTimeColumn is always an integer
b43fad7
@goetas
allow dump schema when migrations in other namespaces are present
71485dc
@goetas
mark as executed only if all queries pass (including the transaction …
5f343d4 
…commit)
@goetas
test changes are not committed on metadata failure
716ea39
@goetas
use executeUpdate for migration queries as it is a write operation
da08c1b
@goetas
test execute update is used for migration queries
cdcf19b
@goetas
get possible storage metadata configs from the config when creating t…
90ecbd6 
…he DI container
@goetas
allow to change logger
bf672b7
@goetas
sharded connection loader
eb75475
@lcobucci
Copy link
Member

@goetas AFAIK the plan is to remove the whole sharding module from DBAL, might be worth to align with @morozov before working on this.

@morozov
Copy link
Member

morozov commented Nov 11, 2019

It's already removed in doctrine/dbal#3595.

@goetas goetas added this to the 3.0.0 milestone Dec 1, 2019
@goetas
Copy link
Member Author

goetas commented Dec 1, 2019

Since this seems removed from doctrine projects, closing the PR.

@goetas goetas closed this Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Won't fix
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@goetas @lcobucci @morozov