Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning for diffCommand #948

Merged
merged 7 commits into from
Mar 22, 2020
Merged

Add warning for diffCommand #948

merged 7 commits into from
Mar 22, 2020

Conversation

goetas
Copy link
Member

@goetas goetas commented Mar 21, 2020 •
edited by greg0ire
Loading

Q A
Type feature
BC Break -
Fixed issues #930

Summary

This is an alternative version of #941

As changes it has

Closes #941

@goetas goetas added this to the 3.0.0 milestone Mar 21, 2020
@goetas goetas mentioned this pull request Mar 21, 2020
Closed
@goetas goetas force-pushed the VincentLanglet-diffWarning branch 2 times, most recently from 0158338 to 69801b4 Compare March 22, 2020 10:45
@goetas
Copy link
Member Author

goetas commented Mar 22, 2020

review suggestions applied

greg0ire
greg0ire reviewed Mar 22, 2020
View reviewed changes
Copy link
Member

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New suggestions to be applied after #949 is merged

tests/Doctrine/Migrations/Tests/Tools/Console/Command/DiffCommandTest.php Outdated Show resolved Hide resolved
tests/Doctrine/Migrations/Tests/Tools/Console/Command/DiffCommandTest.php Outdated Show resolved Hide resolved
tests/Doctrine/Migrations/Tests/Tools/Console/Command/DiffCommandTest.php Outdated Show resolved Hide resolved
tests/Doctrine/Migrations/Tests/Tools/Console/Command/DiffCommandTest.php Outdated Show resolved Hide resolved
tests/Doctrine/Migrations/Tests/Tools/Console/Command/DiffCommandTest.php Outdated Show resolved Hide resolved
goetas and others added 6 commits March 22, 2020 22:11
@goetas
Ask only once if the user wants to continue, independently if it has …
3e30a64 
…unexecuted or new migrations
@goetas @greg0ire
use boolean check for checkNewMigrationsOrExecutedUnavailable
cca89a5 
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
@goetas @greg0ire
Use %d instead of %s for numeric interpolation
d634e05 
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
@goetas @greg0ire
expects->(self::any()) is the default, so not required to be specified
59aab7e 
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
@goetas @greg0ire
Use stubs instead of mocks
0b7a381 
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
@goetas @greg0ire
remove not necessary expectation on mock
a82ef10 
Co-Authored-By: Grégoire Paris <postmaster@greg0ire.fr>
@goetas goetas force-pushed the VincentLanglet-diffWarning branch from dfda29b to a82ef10 Compare March 22, 2020 21:13
@goetas
Copy link
Member Author

goetas commented Mar 22, 2020

rebased

@goetas goetas merged commit f6e4263 into doctrine:master Mar 22, 2020
This was referenced Mar 22, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg0ire greg0ire greg0ire approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@goetas @greg0ire @VincentLanglet