New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove superfluous parameters check on executeUpdate #953

Merged

goetas merged 2 commits into doctrine:master from goetas:execute-update-call

Mar 28, 2020

Member

goetas commented Mar 28, 2020 •

edited

Loading

Q	A
Type	improvement
BC Break	-
Fixed issues

Summary

executeUpdate internally checks the $parameters count, no need to do it here
more precise query timing, by skipping console query output

goetas added 2 commits

March 28, 2020 21:40


          Skip not required parameters check when running the update query

32686e6


          more precise query measurement

f0f1001

goetas added this to the 3.0.0 milestone

greg0ire approved these changes

View reviewed changes

goetas merged commit ed5b127 into doctrine:master

goetas deleted the execute-update-call branch

March 28, 2020 22:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet