-
-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "from-empty-schema" option for "diff" command #981
Conversation
Not tested yet (hence draft) but WDYT? |
Update: I have tested the patch locally and I confirm it works as expected 😃 (but writing an automated test would be another story...) |
tests/Doctrine/Migrations/Tests/Tools/Console/Command/DiffCommandTest.php
Show resolved
Hide resolved
I like this change! A test should test the |
@goetas: Thanks, I have added tests (but I'm not sure because I couldn't mock the |
tests/Doctrine/Migrations/Tests/Generator/DiffGeneratorTest.php
Outdated
Show resolved
Hide resolved
I don't know why the "continuous-integration/travis-ci" check is blocked at "Expected — Waiting for status to be reported"... you can see that it passed: https://travis-ci.org/github/doctrine/migrations/builds/700372177 Anyway, this is now ready for review @goetas 🙂 |
Please kindly squash your commits together. If you don't, we'll try to remember to do it for you but it's best if you save us this trouble. How to do that?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add some documentation?
@greg0ire: done and done ;) |
thanks @guilliamxavier I think that I will have fun times when merging back this to |
- Total issues resolved: **0** - Total pull requests resolved: **6** - Total contributors: **6** - [1032: Let composer decide the best version](#1032) thanks to @PowerKiKi - [1020: Add badges into README about license and packagist](#1020) thanks to @matks - [999: Allow using on PHP 7.1 with Composer 2](#999) thanks to @nicolas-grekas - [981: Add "from-empty-schema" option for "diff" command](#981) thanks to @guilliamxavier - [954: Make compared tables order idempotent](#954) thanks to @julienfalque - [888: Use executeUpdate instead of executeQuery for write operation](#888) thanks to @goetas
- Total issues resolved: **0** - Total pull requests resolved: **6** - Total contributors: **6** - [1032: Let composer decide the best version](#1032) thanks to @PowerKiKi - [1020: Add badges into README about license and packagist](#1020) thanks to @matks - [999: Allow using on PHP 7.1 with Composer 2](#999) thanks to @nicolas-grekas - [981: Add "from-empty-schema" option for "diff" command](#981) thanks to @guilliamxavier - [954: Make compared tables order idempotent](#954) thanks to @julienfalque - [888: Use executeUpdate instead of executeQuery for write operation](#888) thanks to @goetas
- Total issues resolved: **0** - Total pull requests resolved: **6** - Total contributors: **6** - [1032: Let composer decide the best version](#1032) thanks to @PowerKiKi - [1020: Add badges into README about license and packagist](#1020) thanks to @matks - [999: Allow using on PHP 7.1 with Composer 2](#999) thanks to @nicolas-grekas - [981: Add "from-empty-schema" option for "diff" command](#981) thanks to @guilliamxavier - [954: Make compared tables order idempotent](#954) thanks to @julienfalque - [888: Use executeUpdate instead of executeQuery for write operation](#888) thanks to @goetas
Thanks @guilliamxavier |
Summary
Allow to execute
migrations:diff --from-empty-schema
(as alternative to
migrations:dump-schema
but using the mapping instead of the database)