Fix the ' needs an Object' exception for simple references #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alcaeus Is there a way to start the build again without pushing a dummy commit? |
Not sure if you can do it yourself but I just restarted the failing build. |
|
Thanks. Looks like everything is working now. Do I need to create a pull request for master, or will you do that manually? |
|
I'll merge it down after merging it into 1.0 - should get to it either tonight or no later than tomorrow. Thanks for your effort! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug discovered in #1349 and planned to be solved in #1405, but created this fix for the 1.0.x branch first.