-
-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.0] Use storeAs=dbRef as the new default setting for references #1502
Conversation
@coudenysj thanks for the PR! Overally looks good, you have some places with commented out code in the tests though, I think you wanted to remove them? :) About the |
@malarzm The commented assertions are because I was not sure if I should remove the assertions or change the mapping information. I think I'll go with removing the assertions. |
b585acf
to
d0ff8b7
Compare
@coudenysj would you mind rebasing this atop current |
5faea9d
to
45167fa
Compare
@malarzm done |
@coudenysj I think something went wrong as PR still has 11 commits instead of 2 you've made :) |
Also if you could squash these two that would allow me to push the green button instead of doing the merge manually ;) |
45167fa
to
09f4cba
Compare
The rebase was corrected, can't you merge pull requests with multiple commits? |
I can (and often I do) but the 2nd commit doesn't bring anything to the history so there's no point in having it :) |
09f4cba
to
c8b9718
Compare
Correct. Done! |
Thank you! \o/ |
As suggested in 30285e4, the recommended setting of
storeAs=dbRef
will become the default setting in 2.0.@malarzm I had to update my composer.json locally to be able to run phpunit (see #1463).