Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong capitalisation of attributes for GridFS mappings #1926

Merged

Conversation

alcaeus
Copy link
Member

@alcaeus alcaeus commented Jan 9, 2019

Q A
Type bug
BC Break yes

Summary

An unfortunate BC break, looks like we didn't properly clean up GridFS attribute names before merging the PR, which is why we have to change some more writeConcern and fieldName attribute names.

This PR also updates these in the documentation which was omitted before.

@alcaeus alcaeus added this to the 2.0.0-Beta2 milestone Jan 9, 2019
@alcaeus alcaeus self-assigned this Jan 9, 2019
@alcaeus alcaeus merged commit 181edb9 into doctrine:master Jan 9, 2019
@alcaeus alcaeus deleted the fix-wrong-gridfs-attribute-capitalisation branch January 9, 2019 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants