Renamed scheduledForDirtyCheck #1938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
requested changes
Jan 21, 2019
There was a problem hiding this comment.
Please remove unrelated files from this PR and squash commits.
FWIW, you may want to take a look at global .gitignore to avoid accidentally checking in IDE folders.
|
Oh, Thanks. I totally did not see those. Very good tip with the global .gitignore! |
|
There's also a composer PHAR file which has no place in the repo 😉 Also, can you please squash commits? Let me know if you need help with that. |
Also renamed the setter. These names are now the same as in the ORM.
juliusstoerrle
force-pushed
the
patch-2
branch
from
e65a6cb to
c71f83f
Compare
alcaeus
approved these changes
Jan 21, 2019
|
Thanks @juliusstoerrle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Saw this @todo in the code and thought I might aswell just fix it.
These names are now the same as in the ORM.
I guess this is a BC break if people used the UOW directly, should this change be included in the Upgrade/Changelog? (#1696)