Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3] Optimize nested collection deletions #1948

Merged
merged 8 commits into from
Feb 7, 2019
Merged

[1.3] Optimize nested collection deletions #1948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5af6fae
Implemented CollectionPersister::deleteAll method for simultaneous de…
watari Oct 19, 2018
1c9af33
Added check for sub-paths before collections removal in CollectionPer…
watari Oct 22, 2018
086d111
Updated CollectionPersister logic for handling nested collections sch…
watari Oct 24, 2018
7dea62d
Reduced complexity of CollectionPersister::excludeSubPaths method.
watari Oct 26, 2018
99c70c2
Merge remarks implemented.
watari Nov 12, 2018
01898f8
Simplified methods for working with nested collections, remove redund…
watari Nov 27, 2018
fcd68ef
Updated existing tests for CollectionPersister for tracking executed …
watari Nov 29, 2018
f122613
Add BC layer for optimized collection operations
alcaeus Feb 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions UPGRADE-1.3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,13 @@ cause an exception in 2.0. It is possible to have multiple fields with the same
name in the database as long as all but one of them have the `notSaved` option
set.

## Persisters

* The `delete` and `update` methods in
`Doctrine\ODM\MongoDB\Persisters\CollectionPersister` are deprecated. Use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"are" here should likely change but I'm leaving this for a future proofreading :)

`deleteAll` and `updateAll` instead. The method signatures will be adapted
to match those of `deleteAll` and `updateAll` in 2.0.

## Proxies

* The usage of proxies from Doctrine Common was deprecated and will be replaced
Expand Down
Loading