-
-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove previously deprecated operations from Query Builder #1956
Conversation
Correct, we dropped those for the reasons you mentioned below: Double-checking I also just realised that we haven't documented these removals at all. Feel free to add that to this PR. |
@alcaeus: I think this is ready for another look. |
This looks good. I've created #2001 to add the corresponding deprecations for 1.3. Since the large refactoring in the Query and QueryBuilder classes will cause conflicts either way, I'm also perfectly fine merging this PR to 2.0 before merge #2001 to 1.3. Since we didn't document all deprecations properly in the code when starting 2.0, there will be more instances like this where we add deprecations to 1.3 after dropping the corresponding code in 2.0. |
FWIW I've just merged #2001 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - waiting for #2003 to fix the build before merging this. Thanks Jeremy!
geoNear and mapReduce are no longer supported in Query
ODM removed support for geoNear commands in its query builder. Applications should use the $geoNear aggregation pipeline operator instead.
ad6194f
to
e236a0b
Compare
These helpers were originally removed when porting Doctrine MongoDB's query builder over to ODM (doctrine#1553 for 2.0.0-beta1); however, some traces remained in the public API, docs, and test suite.
e236a0b
to
62eed4d
Compare
Summary
The
TYPE_GEO_LOCATION
constant was already marked for removal in a comment. I assume this was an outstanding todo item.While revising the
Builder::limit()
comment, I also realized that the ODM 2.0 Query Builder no longer supportsgroup
andmapReduce
commands. I didn't find any open issues for implementing them, so I assume they were both intentionally dropped when porting over code fromdoctrine/mongodb
. Let me know if you'd like to remove those as well and I can update this PR and create an entry inCHANGELOG-2.0.md
.As you know,
group
has been deprecated since MongoDB 3.4.mapReduce
is not yet deprecated, but I expect it will be once Javascript support is integrated into the aggregation pipeline (no ETA on that).