Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing addFields method for Stage abstract #1967

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Add missing addFields method for Stage abstract #1967

merged 1 commit into from
Mar 5, 2019

Conversation

Steveb-p
Copy link
Contributor

@Steveb-p Steveb-p commented Mar 5, 2019

Q A
Type improvement
BC Break no
Fixed issues none

Summary

Introduces addFields method to Stage abstract, which was probably mistakenly omitted when Stage\AddFields was added.

@alcaeus alcaeus self-assigned this Mar 5, 2019
@alcaeus alcaeus added the Bug label Mar 5, 2019
@alcaeus alcaeus added this to the 2.0.0-Beta2 milestone Mar 5, 2019
@alcaeus
Copy link
Member

alcaeus commented Mar 5, 2019

Thanks @Steveb-p!

@alcaeus alcaeus merged commit a5598e8 into doctrine:master Mar 5, 2019
@Steveb-p Steveb-p deleted the patch-add-fields branch March 5, 2019 15:29
@Steveb-p
Copy link
Contributor Author

Steveb-p commented Mar 6, 2019

@alcaeus you need/want a PR for backport to 1.2/1.3, or you'll cherry pick it?

@alcaeus
Copy link
Member

alcaeus commented Mar 6, 2019

This isn’t necessary in 1.x as it will continue to use the method from doctrine/mongodb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alcaeus alcaeus

Labels
Bug
Projects
None yet
Milestone
2.0.0-RC1
Development

Successfully merging this pull request may close these issues.
2 participants
@Steveb-p @alcaeus