Fix wrong usage of discriminator map in complex document inheritance chains #2025
+208
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malarzm
reviewed
May 3, 2019
alcaeus
force-pushed
the
fix-wrong-discriminator-inheritance
branch
from
89b7c60 to
e7d240c
Compare
malarzm
approved these changes
May 3, 2019
|
Thanks @alcaeus! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See #1962 for details. This brings the wanted functionality into 2.0 as we can't have it in 1.x due to a regression with partial discriminator maps. While #2024 wants the same behaviour for inheritance chains without discriminators, this isn't possible since the subclasses of a particular class aren't known.