Run tests with MongoDB 8.0 replica set #2798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cannot insert into a time-series collection in a multi-document transaction: doctrine_odm_tests.TimeSeriesDocument
There was a problem hiding this comment.
Pull Request Overview
This PR fixes test failures when running with MongoDB 8.0 replica set configuration by adjusting transaction handling and adding replication synchronization logic.
- Disables transactions for time series document operations which are incompatible with MongoDB 8.0 replica sets
- Adds retry logic with backoff for read preference tests to handle replication lag
- Includes MongoDB 8.0 replica set configuration in CI workflow
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/Doctrine/ODM/MongoDB/Tests/Functional/TimeSeriesTest.php | Disables transactions for time series operations to fix compatibility with MongoDB 8.0 |
| tests/Doctrine/ODM/MongoDB/Tests/Functional/ReadPreferenceTest.php | Adds retry mechanism with delays to handle replication lag in replica set environments |
| .github/workflows/continuous-integration.yml | Adds MongoDB 8.0 replica set test configuration to CI matrix |
GromNaN
commented
Aug 8, 2025
Comment on lines
+62
to
+68
| $retries = 0; | ||
| do { | ||
| // Wait a bit to ensure replication has caught up. | ||
| usleep(1_000 * $retries); | ||
| $user = $query->getSingleResult(); | ||
| } while ($user === null && $retries++ < 100); | ||
|
|
Member
Author
There was a problem hiding this comment.
Fix this error:
1) Doctrine\ODM\MongoDB\Tests\Functional\ReadPreferenceTest::testHintIsSetOnQuery with data set #1 ('secondaryPreferred', [])
Failed asserting that null is an instance of class Documents\User.
/home/runner/work/mongodb-odm/mongodb-odm/tests/Doctrine/ODM/MongoDB/Tests/Functional/ReadPreferenceTest.php:61
2) Doctrine\ODM\MongoDB\Tests\Functional\ReadPreferenceTest::testHintIsSetOnQuery with data set #2 ('secondary', [['east'], []])
Failed asserting that null is an instance of class Documents\User.
|
|
||
| $this->dm->persist($document); | ||
| $this->dm->flush(); | ||
| $this->dm->flush(['withTransaction' => false]); |
Member
Author
There was a problem hiding this comment.
Fix this error:
1) Doctrine\ODM\MongoDB\Tests\Functional\TimeSeriesTest::testCreateTimeSeriesDocumentWithoutId
MongoDB\Driver\Exception\BulkWriteException: time-series insert failed: doctrine_odm_tests.TimeSeriesDocument :: caused by :: Cannot insert into a time-series collection in a multi-document transaction: doctrine_odm_tests.TimeSeriesDocument
/home/runner/work/mongodb-odm/mongodb-odm/vendor/mongodb/mongodb/src/Operation/InsertMany.php:134
/home/runner/work/mongodb-odm/mongodb-odm/vendor/mongodb/mongodb/src/Collection.php:854
/home/runner/work/mongodb-odm/mongodb-odm/lib/Doctrine/ODM/MongoDB/Persisters/DocumentPersister.php:230
/home/runner/work/mongodb-odm/mongodb-odm/lib/Doctrine/ODM/MongoDB/UnitOfWork.php:1186
/home/runner/work/mongodb-odm/mongodb-odm/lib/Doctrine/ODM/MongoDB/UnitOfWork.php:3120
/home/runner/work/mongodb-odm/mongodb-odm/lib/Doctrine/ODM/MongoDB/UnitOfWork.php:467
/home/runner/work/mongodb-odm/mongodb-odm/lib/Doctrine/ODM/MongoDB/UnitOfWork.php:3172
/home/runner/work/mongodb-odm/mongodb-odm/lib/Doctrine/ODM/MongoDB/UnitOfWork.php:464
/home/runner/work/mongodb-odm/mongodb-odm/lib/Doctrine/ODM/MongoDB/DocumentManager.php:585
/home/runner/work/mongodb-odm/mongodb-odm/tests/Doctrine/ODM/MongoDB/Tests/Functional/TimeSeriesTest.php:44
|
|
||
| $this->dm->persist($document); | ||
| $this->dm->flush(); | ||
| $this->dm->flush(['withTransaction' => false]); |
Member
Author
There was a problem hiding this comment.
Fix this error:
2) Doctrine\ODM\MongoDB\Tests\Functional\TimeSeriesTest::testCreateTimeSeriesDocumentWithId
MongoDB\Driver\Exception\BulkWriteException: time-series insert failed: doctrine_odm_tests.TimeSeriesDocument :: caused by :: Cannot insert into a time-series collection in a multi-document transaction: doctrine_odm_tests.TimeSeriesDocument
/home/runner/work/mongodb-odm/mongodb-odm/vendor/mongodb/mongodb/src/Operation/InsertMany.php:134
/home/runner/work/mongodb-odm/mongodb-odm/vendor/mongodb/mongodb/src/Collection.php:854
/home/runner/work/mongodb-odm/mongodb-odm/lib/Doctrine/ODM/MongoDB/Persisters/DocumentPersister.php:230
/home/runner/work/mongodb-odm/mongodb-odm/lib/Doctrine/ODM/MongoDB/UnitOfWork.php:1186
/home/runner/work/mongodb-odm/mongodb-odm/lib/Doctrine/ODM/MongoDB/UnitOfWork.php:3120
/home/runner/work/mongodb-odm/mongodb-odm/lib/Doctrine/ODM/MongoDB/UnitOfWork.php:467
/home/runner/work/mongodb-odm/mongodb-odm/lib/Doctrine/ODM/MongoDB/UnitOfWork.php:3172
/home/runner/work/mongodb-odm/mongodb-odm/lib/Doctrine/ODM/MongoDB/UnitOfWork.php:464
/home/runner/work/mongodb-odm/mongodb-odm/lib/Doctrine/ODM/MongoDB/DocumentManager.php:585
/home/runner/work/mongodb-odm/mongodb-odm/tests/Doctrine/ODM/MongoDB/Tests/Functional/TimeSeriesTest.php:60
alcaeus
approved these changes
Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes tests failing with this configuration.