-
-
Notifications
You must be signed in to change notification settings - Fork 516
[BC break] Move doctrine/cache to optional dependencies
#2912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GromNaN
wants to merge
8
commits into
doctrine:2.16.x
Choose a base branch
from
GromNaN:doctrine-cache
base: 2.16.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctrine/cachedoctrine/cache to optional dependencies
8d2ab77 to
58b7c90
Compare
doctrine/cache to optional dependenciesdoctrine/cache to optional dependencies
greg0ire
reviewed
Nov 15, 2025
Member
greg0ire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The quick fix and the proper fix should probably be mentioned in an upgrade guide.
47984e1 to
ff0af5a
Compare
malarzm
approved these changes
Nov 18, 2025
greg0ire
reviewed
Nov 18, 2025
greg0ire
approved these changes
Nov 18, 2025
Co-authored-by: Grégoire Paris <postmaster@greg0ire.fr>
8f014e0 to
8f9a849
Compare
jmikola
reviewed
Nov 26, 2025
Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
Co-authored-by: Jeremy Mikola <jmikola@gmail.com>
alcaeus
approved these changes
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
doctrine/cacheis deprecated and archived.Motivation for introducing a breaking change:
doctrine/mongodb-odmwith composer, you get a message even ifdoctrine/cacheis not actively used.This is a breaking change only when calling
Configuration::getMetadataCacheImpl(). The workaround is easy: adddoctrine/cacheas project dependency.I consider projects that use
doctrine/cachedirectly without explicitly requiring the package to be in error.That's why I'm adding a conflict with
doctrine/mongodb-odm-bundle < 5, which did not have an explicit dependency but used theDoctrine\Common\Cacheclasses:https://github.com/doctrine/DoctrineMongoDBBundle/blob/48c29009c24ff74c47782c0c9c2736f1f5fd9b0e/DependencyInjection/DoctrineMongoDBExtension.php#L14-L15