Removed $cmd args/properties (Mongo command character) #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting this pull request to avoid raising the
MongoDB command prefix option is no longer usederror when using the latest doctrine/mongodb (which deprecated$cmdin doctrine/mongodb pull request #131: doctrine/mongodb#131).I did leave three literal
$artifacts in__construct()methods of some extending objects (\Doctrine\ODM\MongoDB\Query\Query,\Doctrine\ODM\MongoDB\Query\Exprand – even though not strictly required to make code pass unit tests –\Doctrine\ODM\MongoDB\Query\Builder), for compatibility with versions 1.0.3 and earlier of doctrine/mongodb.Resulting code passes all unit tests (aside from
Doctrine\ODM\MongoDB\Tests\Functional\DateTest::testOldDate, which produced an error before the changes and still does afterwards).