This repository has been archived by the owner on Nov 11, 2020. It is now read-only.
ArrayIterator fixes and unit tests #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
This is necessary for supporting with [] operator to append elements.
Check key()'s return value instead, since it will not be confused for a legitimate array key.
jmikola
added a commit
that referenced
this pull request
Aug 9, 2013
ArrayIterator fixes and unit tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few things:
[]valid()might report incorrectly if an element value wasfalseIt leaves the following behaviors in place:
offsetExists()simply callsisset(), so it can't differentiate between offsets not existing and existing but with anullvalue. There isn't a good resolution for this (see: this php.net bug report).offsetGet()will returnnulleven if the offset doesn't exist. Keeping this in place for BC, but I think the proper behavior would be to error out.