This repository has been archived by the owner on Nov 11, 2020. It is now read-only.
DBRef database/collection method improvements #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is incredibly trivial, and there is little value in dispatching events or logging its calls.
This is being removed for the same reason as the Collection method (creating DBRefs is a very trivial operation).
Also create unit test for Database's event dispatching.
jmikola
added a commit
that referenced
this pull request
Aug 12, 2013
DBRef database/collection method improvements
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
createDBRef()should not use array type hinting (arg can be a document or an ID)createDBRef()should not dispatch events, nor should it be loggedDatabase::getDBRef()(Collection already had this)