This repository has been archived by the owner on Nov 11, 2020. It is now read-only.
Open up aggregation builder API for use in ODM #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
force-pushed
the
aggregation-builder-interfaces
branch
from
48134d7 to
eb79c83
Compare
| @@ -42,7 +42,7 @@ class Builder | |||
| /** | |||
| * @var Stage[] | |||
| */ | |||
| private $stages; | |||
| private $stages = []; | |||
There was a problem hiding this comment.
Depending on how long this PR will stay open, could we add this change separately in the next release? Calling getPipeline on a new Aggregation Builder will break because of the non-array $stages in the array_map call.
alcaeus
force-pushed
the
aggregation-builder-interfaces
branch
2 times, most recently
from
85cffe4 to
c3a27c4
Compare
alcaeus
force-pushed
the
aggregation-builder-interfaces
branch
from
c3a27c4 to
03ceeb1
Compare
alcaeus
changed the title
alcaeus
force-pushed
the
aggregation-builder-interfaces
branch
from
72692f5 to
9a064c3
Compare
8 tasks
alcaeus
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR collects all changes necessary to support hydrated aggregation results in doctrine/mongodb-odm#1263.