Skip to content

Commit

Permalink
Address review comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
beberlei committed Nov 7, 2020
1 parent 35c6866 commit 4601127
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ on:
- "*.x"
- "master"

env:
fail-fast: true

jobs:
phpunit-smoke-check:
name: "PHPUnit with SQLite"
Expand Down Expand Up @@ -79,7 +82,7 @@ jobs:
POSTGRES_PASSWORD: "postgres"

options: >-
--health-cmd "pg_isready || psql -U postgres -c 'SELECT 1'"
--health-cmd "pg_isready"
ports:
- "5432:5432"
Expand Down Expand Up @@ -189,7 +192,6 @@ jobs:
--health-cmd "mysqladmin ping --silent"
-e MYSQL_ALLOW_EMPTY_PASSWORD=yes
-e MYSQL_DATABASE=doctrine_tests
${{ matrix.custom-entrypoint }}
ports:
- "3306:3306"
Expand All @@ -215,9 +217,6 @@ jobs:
key: "php-${{ matrix.php-version }}-composer-locked-${{ hashFiles('composer.lock') }}"
restore-keys: "php-${{ matrix.php-version }}-composer-locked-"

- name: "Extensions"
run: "php -r 'var_dump(get_loaded_extensions());'"

- name: "Install dependencies with composer"
run: "composer update --no-interaction --no-progress --no-suggest"

Expand Down

0 comments on commit 4601127

Please sign in to comment.