Remove PHP 7 workarounds (#11324)

phpcs.xml.dist

@@ -274,9 +274,4 @@
  <!-- https://github.com/doctrine/orm/issues/8537 -->
  <exclude-pattern>src/QueryBuilder.php</exclude-pattern>
  </rule>
-
- <rule ref="SlevomatCodingStandard.PHP.UselessParentheses">
- <!-- We need those parentheses to make enum access seem like valid syntax on PHP 7 -->
- <exclude-pattern>src/Mapping/Driver/XmlDriver.php</exclude-pattern>
- </rule>
 </ruleset>

src/Internal/CriteriaOrderings.php

@@ -26,9 +26,7 @@ private static function getCriteriaOrderings(Criteria $criteria): array
  }
 
  return array_map(
- static function (Order $order): string {
- return $order->value;
- },
+ static fn (Order $order): string => $order->value,
  $criteria->orderings(),
  );
  }
@@ -45,9 +43,7 @@ private static function mapToOrderEnumIfAvailable(array $orderings): array
  }
 
  return array_map(
- static function (string $order): Order {
- return Order::from(strtoupper($order));
- },
+ static fn (string $order): Order => Order::from(strtoupper($order)),
  $orderings,
  );
  }

src/Mapping/Driver/XmlDriver.php

@@ -18,10 +18,10 @@
 use SimpleXMLElement;
 
 use function assert;
-use function class_exists;
 use function constant;
 use function count;
 use function defined;
+use function enum_exists;
 use function explode;
 use function extension_loaded;
 use function file_get_contents;
@@ -408,7 +408,7 @@ public function loadMetadataForClass($className, PersistenceClassMetadata $metad
  /** @psalm-suppress DeprecatedConstant */
  $orderBy[(string) $orderByField['name']] = isset($orderByField['direction'])
  ? (string) $orderByField['direction']
- : (class_exists(Order::class) ? (Order::Ascending)->value : Criteria::ASC);
+ : (enum_exists(Order::class) ? Order::Ascending->value : Criteria::ASC);
  }
 
  $mapping['orderBy'] = $orderBy;
@@ -537,7 +537,7 @@ public function loadMetadataForClass($className, PersistenceClassMetadata $metad
  /** @psalm-suppress DeprecatedConstant */
  $orderBy[(string) $orderByField['name']] = isset($orderByField['direction'])
  ? (string) $orderByField['direction']
- : (class_exists(Order::class) ? (Order::Ascending)->value : Criteria::ASC);
+ : (enum_exists(Order::class) ? Order::Ascending->value : Criteria::ASC);
  }
 
  $mapping['orderBy'] = $orderBy;