Address feedback from GH review

doctrine · Jan 3, 2024 · 7cf8311 · 7cf8311
1 parent 84a76a9
commit 7cf8311
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 5 deletions.
diff --git a/lib/Doctrine/ORM/Internal/StronglyConnectedComponents.php b/lib/Doctrine/ORM/Internal/StronglyConnectedComponents.php
@@ -76,7 +76,11 @@ final class StronglyConnectedComponents
      */
     private $representingNodes = [];
 
-    /** @var array<int> */
+    /**
+     * Stack with OIDs of nodes visited in the current state of the DFS
+     *
+     * @var list<int>
+     */
     private $stack = [];
 
     /** @param object $node */

diff --git a/tests/Doctrine/Tests/ORM/Functional/Ticket/GH10912Test.php b/tests/Doctrine/Tests/ORM/Functional/Ticket/GH10912Test.php
@@ -72,15 +72,14 @@ public function testIssue(): void
 
         $this->_em->flush();
 
-        $queries = array_values(array_filter($queryLog->queries, static function ($entry) {
+        $queries = array_values(array_filter($queryLog->queries, static function (array $entry): bool {
             return strpos($entry['sql'], 'DELETE') === 0;
         }));
 
         self::assertCount(3, $queries);
 
-        // $room deletion is the first query
         // we do not care about the order of $user vs. $profile, so do not check them.
-        self::assertSame('DELETE FROM GH10912Room WHERE id = ?', $queries[0]['sql']);
+        self::assertSame('DELETE FROM GH10912Room WHERE id = ?', $queries[0]['sql'], '$room deletion is the first query');
 
         // The EntityManager is aware that all three entities have been deleted (sanity check)
         $im = $this->_em->getUnitOfWork()->getIdentityMap();

diff --git a/tests/Doctrine/Tests/ORM/Functional/Ticket/GH10913Test.php b/tests/Doctrine/Tests/ORM/Functional/Ticket/GH10913Test.php
@@ -115,7 +115,7 @@ private function flushAndAssertNumberOfDeleteQueries(int $expectedCount): void
 
         $this->_em->flush();
 
-        $queries = array_values(array_filter($queryLog->queries, static function ($entry) {
+        $queries = array_values(array_filter($queryLog->queries, static function (array $entry): bool {
             return strpos($entry['sql'], 'DELETE') === 0;
         }));