Address deprecation of SchemaDiff::toSql()

The new method AbstractPlatform::getAlterSchemaSQL() should be preferred when available.
doctrine · Oct 23, 2022 · ac94d82 · ac94d82
1 parent f33919d
commit ac94d82
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/Doctrine/ORM/Tools/SchemaTool.php b/lib/Doctrine/ORM/Tools/SchemaTool.php
@@ -959,7 +959,11 @@ public function getUpdateSchemaSql(array $classes, $saveMode = false)
  return $schemaDiff->toSaveSql($this->platform);
  }
 
- return $schemaDiff->toSql($this->platform);
+ if (! method_exists(AbstractPlatform::class, 'getAlterSchemaSQL')) {
+ return $schemaDiff->toSql($this->platform);
+ }
+
+ return $this->platform->getAlterSchemaSQL($schemaDiff);
  }
 
  /**

diff --git a/tests/Doctrine/Tests/ORM/Functional/SchemaTool/DDC214Test.php b/tests/Doctrine/Tests/ORM/Functional/SchemaTool/DDC214Test.php
@@ -4,6 +4,7 @@
 
 namespace Doctrine\Tests\ORM\Functional\SchemaTool;
 
+use Doctrine\DBAL\Platforms\AbstractPlatform;
 use Doctrine\DBAL\Platforms\SqlitePlatform;
 use Doctrine\DBAL\Schema\AbstractSchemaManager;
 use Doctrine\DBAL\Schema\Comparator;
@@ -82,7 +83,10 @@ public function assertCreatedSchemaNeedsNoUpdates(string ...$classes): void
 
  $schemaDiff = $comparator->compareSchemas($fromSchema, $toSchema);
 
- $sql = $schemaDiff->toSql($this->_em->getConnection()->getDatabasePlatform());
+ $sql = method_exists(AbstractPlatform::class, 'getAlterSchemaSQL') ?
+ $this->_em->getConnection()->getDatabasePlatform()->getAlterSchemaSQL($schemaDiff) :
+ $schemaDiff->toSql($this->_em->getConnection()->getDatabasePlatform());
+
  $sql = array_filter($sql, static function ($sql) {
  return ! str_contains($sql, 'DROP');
  });